farm icon indicating copy to clipboard operation
farm copied to clipboard

feat: change the behavior of html minify

Open Huodoo opened this issue 1 year ago • 7 comments

Description: disabled quotes & closed tag removal behavior in html minify

BREAKING CHANGE:

Related issue (if exists):

Huodoo avatar Dec 20 '24 16:12 Huodoo

🦋 Changeset detected

Latest commit: a00c24634b563c53403275198973142f3523eaa0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@farmfe/core Patch
@farmfe-examples/tailwind-next Patch
@farmfe/js-plugin-tailwindcss Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Dec 20 '24 16:12 changeset-bot[bot]

Thanks!

wre232114 avatar Dec 23 '24 03:12 wre232114

CodSpeed Performance Report

Merging #2013 will create unknown performance changes

Comparing Huodoo:feat/changeHtmlMinifyBehavior (a00c246) with main (a785d6f)

Summary

:warning: No benchmarks were detected in both the base of the PR and the PR.\

codspeed-hq[bot] avatar Dec 23 '24 03:12 codspeed-hq[bot]

Thanks for the PR, but there are still some things to do

  1. Execute npx changeset in the project root directory and select @farmfe/core to generate a changeset file, we upgrade the version number according to this file (and this change is considered to be a patch
  2. Because the html generation has changed, the test snapshot needs to be updated. You can do this locally by running pnpm run test -- --update and FARM_UPDATE_SNAPSHOTS=1 cargo test.

shulandmimi avatar Dec 23 '24 16:12 shulandmimi

Thanks for the PR, but there are still some things to do

  1. Execute npx changeset in the project root directory and select @farmfe/core to generate a changeset file, we upgrade the version number according to this file (and this change is considered to be a patch
  2. Because the html generation has changed, the test snapshot needs to be updated. You can do this locally by running pnpm run test -- --update and FARM_UPDATE_SNAPSHOTS=1 cargo test.

Done

Huodoo avatar Dec 24 '24 04:12 Huodoo

error but something wong with pnpm test -- -u ;also in master branch

Huodoo avatar Dec 24 '24 04:12 Huodoo

It seems that there is a problem with the ci of solid ssr example

ErKeLost avatar Jan 08 '25 08:01 ErKeLost