seq2seq icon indicating copy to clipboard operation
seq2seq copied to clipboard

Possible bug in cell.py

Open macul99 opened this issue 7 years ago • 2 comments

I guess the line #100 of cell.py should be 'z1' instead of 'z0':

"f = Activation(self.recurrent_activation)(z0)"

macul99 avatar Oct 14 '17 15:10 macul99

I think so, the code probably is wrong: i = Activation(self.recurrent_activation)(z0) f = Activation(self.recurrent_activation)(z0)

    c = add([multiply([f, c_tm1]), multiply([i, Activation(self.activation)(z2)])])
    o = Activation(self.recurrent_activation)(z3)
    h = multiply([o, Activation(self.activation)(c)])
    y = Activation(self.activation)(W2(h))

Apparently, in this code, f would equal to i, which contradicts with LSTM model.

rtygbwwwerr avatar Oct 26 '17 16:10 rtygbwwwerr

I can't agree more. z1 should be instead of z0.

dsx4602 avatar Nov 21 '17 13:11 dsx4602