Dirk Farin

Results 455 comments of Dirk Farin

Changed in 626b620. Thanks for the test case and analysis.

I understand your point and know that the color-conversion functions are ad-hoc solutions that still need to be improved. In the case above (RGB -> YCbCr) the conversion takes place...

BTW: this is for 4:2:0 only. For 4:2:2 I did not find any information about chroma sample position in the AV1 spec. My guess is that it is colocated with...

As HEVC uses vertically centered for 4:2:0 and colocated on left sample for 4:2:2, let's use the same when encoding AV1.

Thank you, @wantehchang for the background information on AV1. Ok, this is fine with me. If AV1 supports (is going to support) CSP_CENTER, I can make this the default. This...

Thanks @kmilos for pointing out the note about 4:2:2 in the JFIF spec. As there is no consistent way to specify the sample location with the 4:2:2 video codecs, I...

Always using `libde265/filename.h` is fine for me. Includes can be checked by Traves, but it should be a non-essential test.

You can decode single intra frames, but you have to tell the decoder that you pushed in all the data. Otherwise it won't know that there's no data following. You...

Your loop `for(int y = 0; y < height*width; y++)` will only work when you are lucky. Memory outline in general is with `stride` bytes per row. I.e. there may...

Thank you. Please confirm that the issue is fixed with the above change.