django-admin-autocomplete-filter icon indicating copy to clipboard operation
django-admin-autocomplete-filter copied to clipboard

Package stopped working since a few days..

Open yanivtoledano opened this issue 4 years ago • 14 comments

Hi!

First of all, thanks for the great package. Very useful indeed an much needed for the Django admin. I've been using this package over the past few weeks and recently (i.e., over the last few days) it stopped working. Namely: selecting a field from the dropdown search does not trigger the filter to happen - it simply does nothing. Likely has to do with the commits over the last few days as referred to here. Does filtering and selecting work for you?

yanivtoledano avatar Jul 13 '20 22:07 yanivtoledano

@yanivtoledano same here! Strange behaviour... Hope something can be done with it 👍

idchlife avatar Jul 17 '20 19:07 idchlife

When you say that it stopped working in the last few days, do you mean that the same version doesn’t work anymore, or you are installing from master and a recent change breaks things?

merwok avatar Jul 17 '20 20:07 merwok

@merwok version 0.6 in pypi does not apply selected filter. Version 0.5 does (despite the fact that version 0.5 needs class Media: for some bug, it works)

idchlife avatar Jul 17 '20 21:07 idchlife

@merwok see @idchlife for the answer to your question. The latest pypi version does nothing with the selected filter - version 0.5 works just fine however so it's a degradation between v0.5 to v0.6.

yanivtoledano avatar Jul 17 '20 21:07 yanivtoledano

same as @idchlife, selected filter does nothing, installed from pip new, not upgraded.

i-m-d avatar Jul 21 '20 16:07 i-m-d

Do you see errors in the browser javascript console?

merwok avatar Jul 21 '20 21:07 merwok

Hi @merwok! I've been seeing the same thing: 0.6 seems broken; selecting a filter value does nothing. I don't happen to see anything in my browser console. But I suspect the issue is the JS change that's already fixed in the pre_release branch in https://github.com/farhan0581/django-admin-autocomplete-filter/commit/d90905f48499bc2914308299873d73c729775d0d, since that branch seems to work. Would it be possible to push out a new Pypi version that includes the changes in that branch, at least that commit?

jaredahern avatar Jul 21 '20 23:07 jaredahern

It seems indeed that a quick 0.6.1 release would be great!

merwok avatar Jul 21 '20 23:07 merwok

ok, will do a release today to include that fix in the JS file.

farhan0581 avatar Jul 22 '20 09:07 farhan0581

@farhan0581 can you push this out to pypi?

vbabiy avatar Jul 23 '20 14:07 vbabiy

Pypi version 0.6.1 released!

farhan0581 avatar Jul 24 '20 06:07 farhan0581

thank you @farhan0581 now works ok.

is still needed the Media class ??

class Media: pass

i-m-d avatar Jul 24 '20 06:07 i-m-d

I don't think so, it was already addressed in the version 0.6

farhan0581 avatar Jul 24 '20 06:07 farhan0581

I think this issue was fixed in 0.6.1.

And agreed on the media class - that should already be fixed too, with documentation in #42.

jaredahern avatar Mar 01 '21 01:03 jaredahern