sauln

Results 48 comments of sauln

@garethbowen @dianabarsan We seem to have got most of the tests passing, but just wondering if you might not have a quick solve for the issue I'm seeing in testing....

> @fardarter Following up here, the build issue you hit previous has been fixed in `master` so if you rebase you should be able to continue. There's now a conflict...

> @fardarter Following up here, the build issue you hit previous has been fixed in `master` so if you rebase you should be able to continue. There's now a conflict...

> @fardarter Yes let's get this going. > > Steps I think are needed before review... > > 1. Resync and fix the conflicts. > 2. Raise or link this...

> > have a positive value but no rows actually returned in the rows array. > > That's a valid response... the total_rows is the count of rows in the...

> The test that's timing out is "should create reminders". It calls the `getReminderLogs` function multiple times. The first step is to figure out which call is the one that's...

> @fardarter I think I've found it... If you go to the most recent build in github you can download an artifact for the build which contains the logs of...

@garethbowen I have all the tests passing. Would be grateful for some attention when you can spare it.

> @fardarter Let me know when this is ready for another round. @garethbowen I'll tag you directly.

> @fardarter Let me know when this is ready for another round. @garethbowen I think this is ready for another round. Don't think there's a good reason for the tests...