contracts icon indicating copy to clipboard operation
contracts copied to clipboard

ci: add slither static analysis checks

Open varunsrin opened this issue 3 years ago • 3 comments

Motivation

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

  • [ ] The PR title adheres to the conventional commits standard
  • [ ] The PR has been tagged with change type label(s) (i.e. documentation, feature, bugfix, or chore)
  • [ ] The PR's changes adhere to all the requirements in the contribution guidelines
  • [ ] This PR does not require changes to the Farcaster protocol

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers.

varunsrin avatar Mar 04 '23 00:03 varunsrin

Codecov Report

Patch and project coverage have no change.

Comparison is base (8ae8be1) 84.78% compared to head (507fd39) 84.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files           8        8           
  Lines         309      309           
  Branches       81       81           
=======================================
  Hits          262      262           
  Misses         45       45           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Mar 04 '23 00:03 codecov[bot]

Coverage after merging varunsrin/add-slither-part-2 into main will be

94.23%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   BundleRegistry.sol94.29%83.33%100%100%87, 90
   IdRegistry.sol98.15%100%93.75%98.28%480
   NameRegistry.sol94.56%100%87.10%92.39%1072, 1081, 337, 339, 341, 343, 346, 348–349, 351–352, 354–355, 357

github-actions[bot] avatar Mar 04 '23 00:03 github-actions[bot]

closing for now, don't think we want slither in ci just yet

varunsrin avatar Jul 28 '23 22:07 varunsrin