farcaster-node
farcaster-node copied to clipboard
Monerod RPC SSL enabled in tests fails locally
Running the full tests locally on my machine doesn't work with the last argument --rpc-ssl enable
, but it looks like it works in the CI.
@LeoNero I guess it works locally on your machine? Why did you introduced this flag?
monerod:
image: ghcr.io/farcaster-project/containers/monerod:0.18.0.0
command: >
/usr/bin/monerod
--regtest
--p2p-bind-ip 0.0.0.0
--rpc-bind-ip 0.0.0.0
--zmq-rpc-bind-ip 0.0.0.0
--confirm-external-bind
--non-interactive
--offline
--fixed-difficulty 1
--rpc-ssl enabled
EDIT: removing this flag makes my local test pass again.
Oh, for sure CI passes, the flag is not in the base container.
oh! I should have removed it and it passed in the review. Sorry about that. I am working on SSL support and I will open a PR on monero-rpc-rs today. You can remove this flag
Just to make it clear: I was doing SSL tests (and that's why command:
is used in this case), but I forgot to remove it and it was not perceived in the review. You can remove this flag (and the command:
key actually). Sorry about the confusion.
I will open a PR removing it.