boondock icon indicating copy to clipboard operation
boondock copied to clipboard

No support for creating containers

Open Innectic opened this issue 7 years ago • 5 comments

The ability to create containers is super important for a library like this.

Innectic avatar Apr 02 '18 07:04 Innectic

Upon looking closer, there's no control of containers at all

Innectic avatar Apr 03 '18 04:04 Innectic

Yeah, boondock is used by cage, which actually creates and controls containers using docker-compose (and maybe sometimes docker). cage uses boondock for a bunch of things that can't be done using the CLI tools.

The maintenance status of boondock is what Cargo would probably refer to as "passively maintained":

  • If any boondock features used by cage break, Faraday's engineers should fix them quickly. We use cage heavily internally.
  • If anything else breaks, we'll happily accept PRs, and work with people to troubleshoot and find their way around the code.
  • If anybody wants new features, we're happy to accept PRs (provided there are tests and some basic docs!).
  • On the off chance that anybody wants to start the process of porting this to Tokio/async, we'd be absolutely delighted. Note, however, that boondock uses HTTP over sockets on Unix, and it uses a platform-specific IPC method on Windows, so this is harder than it looks.

In general, the Docker HTTP interface is not especially well documented, so adding new features often involves a fair bit of time reading the code of Docker and/or docker-compose.

emk avatar Apr 03 '18 11:04 emk

Fair enough 👍 Started working on container controls last night here: https://github.com/Innectic/boondock/tree/feature/containers

Innectic avatar Apr 03 '18 16:04 Innectic

I've added some container creation logic here along with some basic tests. If people are interested I can make a PR (and add whatever you think should be added before merge).

pgrinaway avatar Mar 19 '19 15:03 pgrinaway

Oh, cool! I would definitely be happy to look at a PR.

emk avatar Apr 18 '19 23:04 emk