Davide Fantino
Davide Fantino
> How does this work when utilising the list? A lot of the Server class seems to search the list of admins by Steam IDs still, e.g.: > > https://github.com/Team-Silver-Sphere/SquadJS/blob/9f9755ed059de608389229e1b72b3425e8b22e4c/squad-server/index.js#L357...
> > > How does this work when utilising the list? A lot of the Server class seems to search the list of admins by Steam IDs still, e.g.: >...
Additionally, the "Fix/" prefix is not appropriate in my opinion, and I would change it to "refactor!: " (see https://www.conventionalcommits.org/en/v1.0.0/)
New changes look good overall. The error handling of the new `getAdminsWithPermission` is very clear and easy to understand.