fantasy-land icon indicating copy to clipboard operation
fantasy-land copied to clipboard

feat: replace dependency picture with a hyperlink map

Open jceb opened this issue 3 years ago • 8 comments

I added the hyperlink map from sanctuary-type-classes as I find it much easier to navigate and consume than the two-fold link list + dependency picture.

jceb avatar Apr 27 '21 13:04 jceb

This is a great improvement!

Note that there is a typo in the semigroupoid link.

CrossEye avatar Apr 27 '21 13:04 CrossEye

Several people raised concerns when I proposed this change in #160.

davidchambers avatar Apr 27 '21 14:04 davidchambers

Hm, shall we include both, i.e. restore the list, restore the figure and place the pre-formatted map below?

jceb avatar Apr 27 '21 15:04 jceb

@joneshf was concerned about maintenance; perhaps he will chime in. Maintaining the graph in sanctuary-type-classes has not proven onerous. We have a script that automatically updates the readme as part of the release process, and the source is easy to edit in Vim or any other editor with a block mode. Furthermore, changes have not been necessary for several years.

I am in favour of the proposed change, but I think we should incorporate a modified version of the aforementioned script.

davidchambers avatar Apr 27 '21 16:04 davidchambers

Sorry, I thought I'd responded to this.

I don't really have an opinion on this stuff these days. I say, do what makes sense to you all.

joneshf avatar Jun 16 '21 03:06 joneshf

I'm in favour of this change, @jceb. Is this pull request up to date? I see that it has been open for more than two years. :sob:

davidchambers avatar Sep 23 '23 19:09 davidchambers

Let me double check😀

jceb avatar Sep 23 '23 19:09 jceb

I rebased the PR. It's now up-to-date.

jceb avatar Sep 24 '23 08:09 jceb