country-list icon indicating copy to clipboard operation
country-list copied to clipboard

Shorten GB display name

Open wilsonpage opened this issue 5 years ago • 4 comments

The recently changed GB display name is:

  • A. Too long to fit in most UIs
  • B. An unfamiliar way to refer to UK. I live in UK and have never heard it called that.

wilsonpage avatar Oct 01 '19 13:10 wilsonpage

@fannarsh can we merge this? The full name is really unfamiliar for most people in the United Kingdom.

izolate avatar Dec 11 '19 13:12 izolate

Just found a way to do it without this PR

overwrite([
      {
        code: 'GB',
        name: 'United Kingdom'
      }
    ])

haochang avatar Jan 22 '20 10:01 haochang

Just found a way to do it without this PR

overwrite([
      {
        code: 'GB',
        name: 'United Kingdom'
      }
    ])

Thank you for this, but I do agree with @wilsonpage here. Without this PR might have taken me longer to find the cause of why:

console.log(getCode('United Kingdom')); // undefined

daniel-unionrealtime avatar Aug 16 '23 07:08 daniel-unionrealtime

Hi all,

A. Too long to fit in most UIs.

Yes, it is quite long

B. An unfamiliar way to refer to UK. I live in UK and have never heard it called that.

But this is what it is named according to the United Nations and the ISO 3166-1-alpha-2 standard.

And the sole purpose of this library is to lookup the ISO 3166-1-alpha-2 standard. You are always welcome to use the overwrite() method to change the names if you want to display another name then the one which is standardised.

fannarsh avatar Sep 06 '23 10:09 fannarsh