django-saml2-auth icon indicating copy to clipboard operation
django-saml2-auth copied to clipboard

Fix: use the get_user_model function so not hard-coded to django user.

Open jheld opened this issue 8 years ago • 7 comments
trafficstars

jheld avatar Apr 27 '17 17:04 jheld

I think this looks good but the README should also be updated to reflect the ability to make this change

juliedavila avatar Oct 25 '17 10:10 juliedavila

Hi,

What work still needs to be done for this feature to be ready to be merged? This will be very useful for the library to be more flexible.

Thanks

rezende avatar Jan 12 '18 12:01 rezende

I've created a project that is a proper auth backend for django for saml2. This is company sponsored and actively maintained as we use it internally. https://github.com/MindPointGroup/django-saml2-pro-auth

juliedavila avatar Jan 12 '18 12:01 juliedavila

Hi all,

I've not totally forgotten about this. This feature was de-prioritized so I let it go. It's probably coming up soon, so I should be able to fix the conflicts easily enough.

However, given that @defionscode has an alternative project, perhaps if it makes sense, you could use that. I haven't looked at that project yet.

jheld avatar Jan 12 '18 18:01 jheld

@jheld Do you mind reviewing this PR for checking if it still applies to most recent versions of Django?

ayr-ton avatar Oct 09 '18 05:10 ayr-ton

@defionscode Do you want to provide a PR with your changes on django-saml2-pro-auth? I would be happy to merge them here and publish to PyPi so the current users of django-saml2-auth get them as well. \o/

ayr-ton avatar Oct 09 '18 05:10 ayr-ton

@ayr-ton well I would but it wouldnt work out, what I've developed wouldnt really be compatible with this as this library isn't an actual AUTH_BACKEND for django so it's not really a 1:1 on diff/patching files

juliedavila avatar Oct 09 '18 14:10 juliedavila