MemoryModule icon indicating copy to clipboard operation
MemoryModule copied to clipboard

fix a bug in PerformBaseRelocation

Open H4ckF0rFun opened this issue 6 months ago • 1 comments

Bug

The end cannot be determined based on whether the Virtual Address of the next IMAGE_BASE_RELOCATION is 0 or not. In fact, it is possible that the next IMAGE_BASE_RELOCATION exceeds the size of the entire directory. The data it contains is completely uncertain.

Instead, use directory size to determine if you've reached the end.

Sample:

image

By the time you get to the end, you have exceeded the size of the entire relocation table, and the memory after that is invalid, which will cause an exception if you use the Virtual Address

image

image

Why does this approach work most of the time?

The secetion in which the relocation table is located is page aligned, and in most cases there is memory for alignment behind the relocation table, which is filled with 0x00.

image

H4ckF0rFun avatar Jan 03 '24 15:01 H4ckF0rFun

And in fact, it is not necessary to determine whether the end is reached based on whether the virtual address of the next block is 0 or not. directory_size and the size of each block are enough to tell if the end is reached.

H4ckF0rFun avatar Jan 03 '24 15:01 H4ckF0rFun