ui icon indicating copy to clipboard operation
ui copied to clipboard

Stacking window 'message' event listeners

Open ExileofAranei opened this issue 1 year ago • 1 comments

Describe the bug

Hi, just noticed that Html plugin does not remove it's listener for message event, plugin's detach function is not called on fancybox destroy so window.removeEventListener is also never called. It tends to adding listeners for such event on each fancybox opening. Sure it won't cause serious performance issues, but it worths mentioning anyway

Tested on my websites with latest version, screenshot is captured on yours image

Reproduction

Open fancybox multiple times and check listeners for message event

Additional context

No response

ExileofAranei avatar Aug 23 '24 08:08 ExileofAranei

Hi, Thanks for the reporting!

fancyapps avatar Aug 23 '24 08:08 fancyapps

This problem doesn't seem to occur in v6, if you do encounter any problems, please let me know.

fancyapps avatar Jul 07 '25 15:07 fancyapps