falling-fruit-web icon indicating copy to clipboard operation
falling-fruit-web copied to clipboard

Add OpenStreetMap map layer

Open ezwelty opened this issue 7 years ago • 2 comments

Many users prefer OpenStreetMap as a basemap because it is much more detailed than Google Maps in some regions. See https://github.com/falling-fruit/falling-fruit/blob/master/app/assets/javascripts/mapcommon.js#L134 for implementation details.

ezwelty avatar Oct 08 '18 10:10 ezwelty

I'm thinking this is a more complicated issue than a first due to the way the google-map-react package works. There is no easy substitution available for the base layer.

haleigh-ziebol avatar Jan 03 '24 20:01 haleigh-ziebol

@halziebol11 Thanks for weighing in. The limitations of google-map-react have also come up in the context of (poor) performance – see #142. We already have a lot of logic written with the Google Maps Javascript API for the current website and mobile app, which makes we wonder whether dropping google-map-react in favor of using the Google Maps Javascript API directly (and so writing our own React wrappers) would be worth it in the long run.

ezwelty avatar Jan 21 '24 21:01 ezwelty