falling-fruit-web icon indicating copy to clipboard operation
falling-fruit-web copied to clipboard

Mobile list is empty if loaded directly from URL

Open ezwelty opened this issue 3 years ago • 3 comments

Going to the list directly from a URL results in an empty list. For example: /list/@40.0405402577959,-105.2632395613161,21z. Locations are not loaded. Only when switching to map view are the locations loaded.

image

ezwelty avatar Jan 13 '23 16:01 ezwelty

This happens because the view object is null when src/redux/selectParams.js is called after loading the empty page, and the error is silenced because src/redux/listSlice.js there is no handler for fetchListLocations.rejected. A very nice bug!

wbazant avatar May 26 '24 21:05 wbazant

Proposed resolution is to require a loaded map - if the /list/ URL is accessed first, briefly visit /map and then come back to /list.

wbazant avatar Jul 27 '24 16:07 wbazant

From https://github.com/falling-fruit/falling-fruit-web/pull/419#issuecomment-2284862604

This seems to be broken in a new way. http://localhost:3000/list/@40.0405403,-105.2632396,21z loads the list, but switching to the map view does not load markers (weirdly I only see one basemap tile loaded, the rest load only after the map is moved), and moving the map does not update the map center and zoom in the URL, such that clicking back to the list always shows the original list.

ezwelty avatar Aug 16 '24 09:08 ezwelty

This is now fixed (I visited https://beta.fallingfruit.org/list/@40.0405402577959,-105.2632395613161,21z and got locations back)

wbazant avatar Sep 26 '24 13:09 wbazant