Falko icon indicating copy to clipboard operation
Falko copied to clipboard

Use Latest node for project and lock it

Open alaxalves opened this issue 7 years ago • 6 comments

Description

We must use Node 9.x in the next docker image to prevent incompatibilities.

Current behavior

Docker use Node Slim based on Node 8.x

Steps to reproduce the behavior

Which steps have been taken to reach the problem?

Checklist

  • [x] This issue has a significant name.
  • [x] This issue has labels.
  • [ ] This issue has screenshots (if necessary).

alaxalves avatar May 03 '18 02:05 alaxalves

If no one's working on this yet I'd love to give this issue a try! Also, would Node 10.x work or do we need Node 9.x in particular?

jrkong avatar Oct 01 '18 18:10 jrkong

If no one's working on this yet I'd love to give this issue a try! Also, would Node 10.x work or do we need Node 9.x in particular?

Hello @jrkong. We would be happy with your contribution. Node 10.x will work indeed. That's an old issue, we propose 9.x because it was the current latest version.

MartinsLucas avatar Oct 03 '18 01:10 MartinsLucas

So I've been doing some testing and I've got a few questions and I would appreciate it if someone could answer:

  1. As I was setting up my dev environment I noticed that the Docker image uses Node version 9.2.0. As that's the case should this issue be closed? Also, I couldn't find details on the Docker image the project uses (alaxalves/front image) so I'm not sure what the structure of the image is.

  2. The Dockerfile is never really used to create the Docker image. Is this intended? If not I'll attempt to make the changes needed.

  3. I want to verify if this issue involves changing the Docker image's Node version or if it involves changing the Travis version as Travis is currently set to Node 8.6.0.

jrkong avatar Oct 08 '18 17:10 jrkong

@jrkong the image uses the structure defined in scrips/docker/Dockerfile.dev, that is the image you found in (alaxalves/front image). About travis, the version defined there is irrelevant since we use docker in Travis

alaxalves avatar Oct 11 '18 14:10 alaxalves

@alaxalves great! So at this point how do we want to handle this issue? Technically speaking the alaxalves/front image image already resolves the issue so what does everyone think our next steps should be?

  1. We can close the issue as the alaxalves/front image resolves it already

  2. Update the docker-compose.yml to use the Dockerfile inside the repository to create the image. Also if we go this route, what is everyone's thoughts on clearly defining the version of the node:slim image used?

jrkong avatar Oct 11 '18 20:10 jrkong

We should update the Dockerfile and lock the node version. Also, Node >10 is required to run Cypress tests inside Travis CI

alaxalves avatar Mar 02 '19 19:03 alaxalves