Falko-API icon indicating copy to clipboard operation
Falko-API copied to clipboard

Send confirmation email for registration

Open guilhermesiqueira opened this issue 5 years ago • 4 comments

Proposed Changes

Upon registration, the system sends an email to the user to confirm their registration.

Type of Change

What kind of changes this Pull Request introduces to Falko?

  • [ ] Bugfix
  • [x] New Feature

Checklist

  • [x] Pull Request's name is self-explanatory and its in English.
  • [x] There are no Rubocop issues.
  • [x] Travis build has success (tests, code climate and codacy checks).
  • [x] Pull Request is linked to an existing issue.
  • [ ] Seeds have been created to the new User Stories.

Other Comments

When creating a new version of the user address, email confirmation is required, so a new version has been created as V1/users. The versioning of the whole API is something that is beyond the scope of this issue, so we opted for the above.

Close #214

guilhermesiqueira avatar Oct 24 '19 03:10 guilhermesiqueira

Is this a WIP PR? Because there's still some tests breaking in the CI tool.

alaxalves avatar Oct 24 '19 12:10 alaxalves

Is this a WIP PR? Because there's still some tests breaking in the CI tool.

Now the PR is complete. Now there is the versioning of endpoint /users, where in v1/users email confirmation is required to register new users.

guilhermesiqueira avatar Oct 24 '19 14:10 guilhermesiqueira

In general, this look ok to me, I just didn't get why there are so many templates that apparently do the same thing. Might be just a technicality tho ¯_(ツ)_/¯

For some reason when I delete templates from the user_mailer folder I get a missing template error. The same happens when I remove templates from the layouts folder. Keeping the two template folders all works beautifully ¯_(ツ)_/¯ Captura de Tela 2019-10-24 às 22 43 42

By the way, sending emails is using Sendgrid. It would be interesting for a project maintainer to create a Sendgrid account and add the key to the environment.rb file on deploy.

guilhermesiqueira avatar Oct 25 '19 01:10 guilhermesiqueira

Hey @alaxalves, I added some exceptions, could you review again?

guilhermesiqueira avatar Nov 16 '19 15:11 guilhermesiqueira