falkTX
Dry/Wet is not correctly panned
Hi there. Steps to reproduce :
-
add a signal generator
-
add a easily recognizable stereo fx (I've used various things but let's try with Rubberband)
-
route signal --> fx --> stereo output of your system
-
set Dry/Wet to -inf (value=0) . At this step you should hear only dry signal on both left and right channels, that is ok.
-
set L to -100 and R to -100. Issue : I can hear both dry and wet signal on Left channel. In fact I can hear wet signal as far as ( R != 100 ) Note that setting L and R to +100 results in only dry signal on Right channel, which is correct. --> Left pan seems not affected, only Right pan seems incorrect.
Bug is still here. We can't use both pan and dry/wet feature, unless if we're ok with unwanted sounds. Should be easily reproducible.
this depends on the plugin format used, as the logic for dry/wet and panning is not the same for everything
@falkTX This is happening with every kind of plugins : lv2, vst, internal.
I'm talking about pan and dry/wet of carla's gui
The following pic is more explicit :
Expected behavior: have only dry signal on left channel
Actual behavior : both dry and wet signal on left channel
I can confirm it with LADSPA plugin and current 2.6.0-alpha1 version: looks like Dry/wet, L, R knobs are working strangely when combined.
Looks like i've fixed that. Please see example patch for CarlaPluginLADSPADSSI.cpp, but same thing most likely is need for CarlaPluginBridge.cpp, CarlaPluginCLAP.cpp, CarlaPluginJack.cpp, CarlaPluginLV2.cpp, CarlaPluginNative.cpp, CarlaPluginVST2.cpp, CarlaPluginVST3.cpp files.
Patches for CarlaPluginLADSPADSSI.cpp, CarlaPluginLV2.cpp, CarlaPluginNative.cpp are included with fresh patch .zip at #1971.