fix(container): crash at filter extract
What type of PR is this? /kind bug
Any specific area of the project related to this PR? /area plugins
What this PR does / why we need it:
I hit a segfault with sinsp-example, just specifying -f 'container.name!=my_container'.
After debugging it I realized that event filtering (using extract cap) happens before parse, so the assumption in the code didn't hold.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Rules files suggestions
LGTM, not sure why CI is unhappy though
I found this in the CI output:
Runtime error: cannot load plugin /usr/share/falco/plugins/libcontainer.so: plugin required API version '3.12.0' not compatible with the framework's API version '3.11.0': framework's minor is less than the requested one. Exiting.
I think this has something to do with https://github.com/falcosecurity/plugins/pull/1005 / https://github.com/falcosecurity/plugins/pull/1016. No idea why this is failing though. CC @ekoops @leogr
CI is still using an old falco:master-debian image to test this, as no new docker images of that kind has been pushed to dockerhub yet. That old image is synced with an old libs version. That's why we are getting this error.
CI is still using an old
falco:master-debianimage to test this, as no new docker images of that kind has been pushed to dockerhub yet. That old image is synced with an old libs version. That's why we are getting this error.
How did the previous one pass then?
What is the previous one? Do you mean the previous merged PR? It failed as well: https://github.com/falcosecurity/plugins/actions/runs/18351059430/job/52271109104
FYI the CI will be fixed once https://github.com/falcosecurity/falco/pull/3689 gets merged. You can ignore it at the moment.
Rules files suggestions
FYI the CI will be fixed once falcosecurity/falco#3689 gets merged. You can ignore it at the moment.
FYI it works now :sunglasses:
LGTM label has been added.
@ekoops @leogr do you mind taking a look?
Rules files suggestions
Rules files suggestions
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deepskyblue86, irozzo-1A, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [leogr]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
LGTM label has been added.