libs icon indicating copy to clipboard operation
libs copied to clipboard

Published 20 hours ago • verified publisher icon falcosecurity

[CLEANUP] Track some modern bpf cleanups

Open Andreagit97 opened this issue 3 years ago • 28 comments

This issue tracks some possible cleanups related to the modern BPF probe

  • [ ] Some refactoring highlighted by @hbrueckner during reviews (thank you for that) :) These are comments on merged PR that's the reason why it seems that we have already addressed them.

    • [ ] https://github.com/falcosecurity/libs/pull/554#discussion_r961591615
    • [ ] https://github.com/falcosecurity/libs/pull/554#discussion_r961595232
    • [ ] https://github.com/falcosecurity/libs/pull/558#discussion_r961670898
    • [ ] https://github.com/falcosecurity/libs/pull/558#discussion_r961761060
    • [ ] https://github.com/falcosecurity/libs/pull/558#discussion_r964999225
    • [ ] https://github.com/falcosecurity/libs/pull/553#discussion_r962981173
    • [ ] https://github.com/falcosecurity/libs/pull/553#discussion_r964763593
    • [ ] https://github.com/falcosecurity/libs/pull/553#discussion_r964783756
    • [ ] https://github.com/falcosecurity/libs/pull/553#discussion_r964793087
    • [ ] https://github.com/falcosecurity/libs/pull/553#discussion_r964862795
    • [ ] https://github.com/falcosecurity/libs/pull/553#discussion_r964897334
    • [ ] https://github.com/falcosecurity/libs/pull/553#discussion_r964917696

  • [ ] Remove libpman and use directly the scap-modern-bpf-engine. libpman was designed before the born of the "new" scap v-table approach. It was a good way to abstract the complexity of the modern probe loading from libscap, and moreover, it helped us in avoiding code duplication in the old modern bpf framework test, but now that we have a dedicated engine for the modern probe and we use directly the engines in the drivers tests, there is probably no more need for libpman. Moreover removing libpman could help us in improving the logging phase in our libraries :)

Andreagit97 avatar Sep 10 '22 14:09 Andreagit97

:partying_face: :balloon:

leogr avatar Sep 13 '22 16:09 leogr

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Dec 12 '22 21:12 poiana

/remove-lifecycle stale

Andreagit97 avatar Dec 13 '22 09:12 Andreagit97

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Mar 16 '23 15:03 poiana

/remove-lifecycle stale

Andreagit97 avatar Mar 16 '23 16:03 Andreagit97

Probably these suggestions will be part of a final cleanup, when the support to all syscalls will be completed :)

Andreagit97 avatar Mar 16 '23 16:03 Andreagit97

Probably these suggestions will be part of a final cleanup, when the support to all syscalls will be completed :)

What's missing here?

leogr avatar Mar 19 '23 14:03 leogr

What's missing here?

All points i would say

Andreagit97 avatar Jun 07 '23 12:06 Andreagit97

Now only libpman cleanup pending?

incertum avatar Aug 23 '23 18:08 incertum

cc @Andreagit97 ?

leogr avatar Aug 24 '23 12:08 leogr

nope we miss all the points here

Andreagit97 avatar Aug 24 '23 13:08 Andreagit97

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Dec 03 '23 15:12 poiana

/remove-lifecycle stale

Andreagit97 avatar Dec 04 '23 09:12 Andreagit97

@Andreagit97 do you plan to work on this?

(if so please /assign it to yourself :pray: )

leogr avatar Dec 05 '23 17:12 leogr

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Mar 04 '24 21:03 poiana

/remove-lifecycle stale

incertum avatar Mar 05 '24 00:03 incertum

@Andreagit97 what's missing here?

leogr avatar Mar 05 '24 09:03 leogr

all the points in the issue!

Andreagit97 avatar Mar 05 '24 10:03 Andreagit97

all the points in the issue!

got it. Sorry, all those merged icons misled me to think there was some progress.

leogr avatar Mar 05 '24 10:03 leogr

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Jun 03 '24 15:06 poiana

/remove-lifecycle stale

Andreagit97 avatar Jun 04 '24 07:06 Andreagit97