libs icon indicating copy to clipboard operation
libs copied to clipboard

update(libsinsp): get_dynamic_field constness

Open deepskyblue86 opened this issue 8 months ago • 4 comments

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area libsinsp

Does this PR require a change in the driver versions?

What this PR does / why we need it: Have get_dynamic_field being const, so it can be used as a regular getter.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

deepskyblue86 avatar Jun 26 '25 13:06 deepskyblue86

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepskyblue86 Once this PR has been reviewed and has the lgtm label, please assign ekoops for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Jun 26 '25 13:06 poiana

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.35%. Comparing base (c4ea330) to head (ee14b3e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2511   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files         281      281           
  Lines       31689    31689           
  Branches     4643     4643           
=======================================
+ Hits        24830    24831    +1     
+ Misses       6859     6858    -1     
Flag Coverage Δ
libsinsp 78.35% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 26 '25 13:06 codecov[bot]

/milestone 0.22.0

FedeDP avatar Jun 26 '25 14:06 FedeDP

/milestone 0.23.0

leogr avatar Sep 24 '25 08:09 leogr