libs icon indicating copy to clipboard operation
libs copied to clipboard

feat(libsinsp): Add wrapper for read/write lock

Open greyhame-s opened this issue 1 year ago • 2 comments

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it: mutex.h already has a nice abstraction that allows exclusive access to an object. This change extends that paradigm to allow similar simple function calls that allow read/write locking primitives using a shared_mutex.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: The timekeeping stats were useful to me during testing, but I am not married to them. It also looks like the .clang-format in the root directory, when applied to this file, resulted in some whitespace changes to otherwise unchanged code. If that is not expected, then I can revert the formatting to existing lines as well.

Does this PR introduce a user-facing change?: No

NONE

greyhame-s avatar May 22 '24 18:05 greyhame-s

/milestone 0.18.0

FedeDP avatar May 23 '24 09:05 FedeDP

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, greyhame-s

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Aug 27 '24 11:08 poiana

LGTM label has been added.

Git tree hash: 6b590b386fabe27e036d12d7aa211685759b18e9

poiana avatar Aug 27 '24 11:08 poiana