[TRACKING] Technical debt cleanup wrt edge case segfaults or memleaks 🧹
We can use this ticket to collectively discuss steps we can take to more programmatically attempt to reduce issues related to more corner case segfaults or memory leaks. It's a challenging task for everyone reading this, and we are not planning to rewrite the libraries in Rust at this time.
@falcosecurity/libs-maintainers
### Tasks
- [ ] https://github.com/falcosecurity/libs/issues/1470
Raw notes from the 2023-11-02 core maintainers meeting:
- Reject raw pointers? We should still replace them with smart pointers whenever possible. This will make ownership more clear and transparent in libsinsp.
- Pass by parameter or by reference when possible.
- Remove things that are not needed from the core code base first. Removing udig and mesos is more difficult because they are more tangled than removing the old k8s client code base. @jasondellaluce volunteered to tackle this (mesos + k8s client removal after we have the new k8s client implementation -> coordinate with @Andreagit97).
- Consider prioritizing removing the respective code lines in
sinsp nextfirst. (@gnosek comment)
From the meeting, as a practical item we mentioned the work we started to support UndefinedBehaviorSanitizer (and we can continue with more sanitizer/safeguards), I have created an issue for it: https://github.com/falcosecurity/libs/issues/1470
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale
What are the next steps here?
I think we have 5+ folks currently cleaning the code base like crazy in many corners, which is amazing :rocket:
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten
remove-lifecycle rotten
/remove-lifecycle rotten
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community. /close
@poiana: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with
/reopen.Mark the issue as fresh with
/remove-lifecycle rotten.Provide feedback via https://github.com/falcosecurity/community. /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.