libs icon indicating copy to clipboard operation
libs copied to clipboard

[Feature] Improve args in `bpf` exit event

Open incertum opened this issue 2 years ago • 16 comments

Based on a discussion between @Andreagit97 @darryk10 and myself a few ideas shared by Andrea to improve bpf syscall based alerting in falco rules:

  • [ ] add the possibility to check the return value, possibly expose evt.arg.cmd also in the exit event to have all fields of interest in one event
  • [x] introduce the BPF commands name, so use evt.arg.cmd == BPF_PROG_LOAD instead of evt.arg.cmd == 5 -> https://github.com/falcosecurity/libs/pull/1545
  • [ ] expose also the name of the BPF prog injected (not easy at all) -> comment @incertum not sure how valuable it would be for detections, maybe not really needed at the moment.

incertum avatar Sep 08 '23 17:09 incertum

this is a duplicate of #1342 but it is more detailed, I will close mine :)

Andreagit97 avatar Sep 11 '23 08:09 Andreagit97

oh 🤦‍♀️ I should have maybe checked before opening this issue.

incertum avatar Sep 11 '23 08:09 incertum

@Andreagit97 @incertum Would love to work on this!!

Rohith-Raju avatar Sep 29 '23 12:09 Rohith-Raju

Awesome, you have any additional questions? Else please feel free to go ahead :) Thanks!

incertum avatar Sep 29 '23 15:09 incertum

I'm going to solve them one by one and will reach out if I get stuck 😄.

Rohith-Raju avatar Oct 02 '23 13:10 Rohith-Raju

Great! Suggesting to focus on the first 2 items in one PR -> easy wins, add direct value to Falco rules in the next release.

The last one may need to be queued depending on prioritization, not a top priority feature.

incertum avatar Oct 02 '23 21:10 incertum

/milestone TBD

incertum avatar Nov 15 '23 05:11 incertum

/milestone 0.15.0

incertum avatar Dec 18 '23 18:12 incertum

Changed milestone to TBD since 2 items are still open and to be discussed. @Rohith-Raju are you still interested in exploring the other 2 items in the future? No immediate urgency.

incertum avatar Mar 07 '24 07:03 incertum

@incertum Yes, I'd love to!!

Rohith-Raju avatar Mar 07 '24 08:03 Rohith-Raju

Awesome @Rohith-Raju likely these items would be for the summer after Falco 0.38.0, but dev and PR review can happen any time before of course!

incertum avatar Mar 07 '24 08:03 incertum

Sure!! I'll reach out to you if I need more info!!

Rohith-Raju avatar Mar 07 '24 08:03 Rohith-Raju

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Jun 05 '24 09:06 poiana

/remove-lifecycle stale

Andreagit97 avatar Jun 05 '24 12:06 Andreagit97

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Sep 03 '24 16:09 poiana

/remove-lifecycle stale

Andreagit97 avatar Sep 03 '24 17:09 Andreagit97

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Dec 02 '24 22:12 poiana

add the possibility to check the return value, possibly expose evt.arg.cmd also in the exit event to have all fields of interest in one event

This could be solved with https://github.com/falcosecurity/libs/pull/2068

Andreagit97 avatar Dec 03 '24 09:12 Andreagit97

/remove-lifecycle stale

Andreagit97 avatar Dec 03 '24 09:12 Andreagit97

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana avatar Jan 02 '25 10:01 poiana

could be partially solved by https://github.com/falcosecurity/libs/pull/1867, at least the first point

add the possibility to check the return value, possibly expose evt.arg.cmd also in the exit event to have all fields of interest in one event

Andreagit97 avatar Jan 02 '25 10:01 Andreagit97

/remove-lifecycle rotten

Andreagit97 avatar Jan 02 '25 10:01 Andreagit97

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Apr 02 '25 16:04 poiana

/remove-lifecycle rotten

Andreagit97 avatar Apr 04 '25 16:04 Andreagit97

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana avatar May 04 '25 22:05 poiana

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community. /close

poiana avatar Jun 04 '25 04:06 poiana

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

poiana avatar Jun 04 '25 04:06 poiana