falco
falco copied to clipboard
new(engine): throw an error when an invalid macro/list name is used
What type of PR is this?
Uncomment one (or more)
/kind <>
lines:
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind release
Any specific area of the project related to this PR?
Uncomment one (or more)
/area <>
lines:
/area build
/area engine
/area tests
/area proposals
/area CI
What this PR does / why we need it: Adds a check for invalid macro/list name so the rule set validation fails before using a wrong name in conditions
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
new(engine): throw an error when an invalid macro/list name is used
BREAKING CHANGE: rule sets with invalid macro/list names will stop working even if such macros/lists are unused
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.
Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.
/hold
test-dev-packages
should pass when this PR in falcosecurity/testing
gets merged
/milestone 0.38.0
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Andreagit97,FedeDP]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/unhold