falco icon indicating copy to clipboard operation
falco copied to clipboard

new(engine): throw an error when an invalid macro/list name is used

Open mrgian opened this issue 11 months ago • 3 comments

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it: Adds a check for invalid macro/list name so the rule set validation fails before using a wrong name in conditions

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(engine): throw an error when an invalid macro/list name is used 
BREAKING CHANGE: rule sets with invalid macro/list names will stop working even if such macros/lists are unused

mrgian avatar Feb 26 '24 17:02 mrgian

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

github-actions[bot] avatar Feb 26 '24 17:02 github-actions[bot]

test-dev-packages should pass when this PR in falcosecurity/testing gets merged

mrgian avatar Feb 28 '24 09:02 mrgian

/milestone 0.38.0

FedeDP avatar Mar 07 '24 09:03 FedeDP

LGTM label has been added.

Git tree hash: 7257d60e7af92021297b8e10845bf8d11a84310f

poiana avatar Mar 07 '24 09:03 poiana

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, mrgian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Mar 07 '24 10:03 poiana

/unhold

incertum avatar Mar 07 '24 23:03 incertum