falco
falco copied to clipboard
fix(scripts): force falco-driver-loader script to try to compile the driver anyway even on unsupported platforms
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
Currently, when falco-driver-loader is not able to fetch OS_NAME from multiple files under /etc, like /etc/os-release
, it exit with an error.
I think that the best approach is trying to compile the requested driver in any case; consider that TARGET_ID
is only really used to concatenate the correct name for the driver on the s3 bucket.
So, in case we are not able to fetch any TARGET_ID, just fallback at disabling ENABLE_DOWNLOAD
and go on to compile the driver.
This is mostly useful when using HOST_ROOT
but the /etc/
folder is not a shared volume under it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
LGTM label has been added.
/milestone 0.33.0
LGTM label has been added.
/milestone 0.34.0
/hold until Falco 0.33.0 is released
/unhold
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jasondellaluce, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [FedeDP,jasondellaluce,leogr]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment