falco icon indicating copy to clipboard operation
falco copied to clipboard

fix(scripts): force falco-driver-loader script to try to compile the driver anyway even on unsupported platforms

Open FedeDP opened this issue 2 years ago • 2 comments

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

What this PR does / why we need it:

Currently, when falco-driver-loader is not able to fetch OS_NAME from multiple files under /etc, like /etc/os-release, it exit with an error. I think that the best approach is trying to compile the requested driver in any case; consider that TARGET_ID is only really used to concatenate the correct name for the driver on the s3 bucket. So, in case we are not able to fetch any TARGET_ID, just fallback at disabling ENABLE_DOWNLOAD and go on to compile the driver. This is mostly useful when using HOST_ROOT but the /etc/ folder is not a shared volume under it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP avatar Sep 22 '22 09:09 FedeDP

LGTM label has been added.

Git tree hash: 5a50819d5b1d1d97967a00532f64a7ec3999cac8

poiana avatar Sep 22 '22 13:09 poiana

/milestone 0.33.0

leogr avatar Sep 26 '22 06:09 leogr

LGTM label has been added.

Git tree hash: 554d3d4d92f388432ec27092586ad907aa477ef3

poiana avatar Sep 27 '22 08:09 poiana

/milestone 0.34.0

FedeDP avatar Sep 27 '22 08:09 FedeDP

/hold until Falco 0.33.0 is released

jasondellaluce avatar Sep 27 '22 08:09 jasondellaluce

/unhold

FedeDP avatar Oct 25 '22 07:10 FedeDP

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Nov 02 '22 11:11 poiana