falco icon indicating copy to clipboard operation
falco copied to clipboard

Published 20 hours ago • verified publisher icon falcosecurity

Rules result add compile condition context

Open mstemm opened this issue 2 years ago • 2 comments

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Also include exact locations for rule condition compile errors (missing macros, etc).

mstemm avatar Sep 20 '22 16:09 mstemm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Sep 20 '22 16:09 poiana

I'm going to wait for the changes in #2206 as that allows referring to things like rule_load_exception independently of the rule loader. Given that filter_rulesets often compile an ast to a filter, we really should document what exceptions filter rulesets can throw so falco knows which ones to catch and convert to rule loading errors.

mstemm avatar Sep 22 '22 16:09 mstemm

/milestone 0.34.0

leogr avatar Sep 27 '22 08:09 leogr

This is ready for review now.

mstemm avatar Oct 10 '22 23:10 mstemm

Sorry for being late, this was pushed over a lot due to the Falco release and KubeCon's attendance from most maintainers. Left you my comments.

jasondellaluce avatar Nov 02 '22 18:11 jasondellaluce

LGTM label has been added.

Git tree hash: 20fefb817c596bd1ad353f0dba4e33802942bff2

poiana avatar Dec 01 '22 10:12 poiana

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [FedeDP,jasondellaluce,mstemm]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Dec 01 '22 16:12 poiana