falco icon indicating copy to clipboard operation
falco copied to clipboard

CI issue: data race in publishing jobs for `-dev` packages

Open leogr opened this issue 2 years ago • 5 comments

Describe the bug

When multiple PRs got merged at the same time, then the CircleCI may run multiple workflows in parallel. In such a situation, a data race occurs while publishing -dev packages to https://download.falco.org/?prefix=packages/ Since the publishing operation also updates RPM and DEB repository metadata, the process may result in corrupted repositories.

This problem happened with #1871 and #1872

However, once another PR gets merged, repository metadata is computed again and the problem disappears.

Only -dev packages are affected. Stable packages are not affected because we just tag a release at a time.

How to reproduce it

No way to reproduce it locally.

Expected behaviour

Additional context

I have opened this PR mostly for the record. Likely, we won't fix it. Final users are not affected by this problem in any way.

leogr avatar Jan 27 '22 16:01 leogr

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Apr 27 '22 17:04 poiana

/remove-lifecycle stale

/help

Just FYI @FedeDP @jasondellaluce

leogr avatar Apr 29 '22 11:04 leogr

@leogr: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/remove-lifecycle stale

/help

Just FYI @FedeDP @jasondellaluce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

poiana avatar Apr 29 '22 11:04 poiana

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Jul 28 '22 15:07 poiana

/remove-lifecycle stale

leogr avatar Aug 02 '22 16:08 leogr

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Oct 31 '22 21:10 poiana

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana avatar Nov 30 '22 21:11 poiana

/remove-lifecycle rotten

This can still happen.

cc @FedeDP @Andreagit97 pls take this into account if you have in mind to renovate a bit our CI :smile_cat:

leogr avatar Dec 16 '22 10:12 leogr

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Mar 16 '23 15:03 poiana

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana avatar Apr 15 '23 19:04 poiana

/remove-lifecycle stale

I think the issue might be fixed when porting Ci to GHA and enforcing a correct concurrency in the master workflow.

FedeDP avatar Apr 15 '23 19:04 FedeDP

/remove-lifecycle rotten

FedeDP avatar Apr 17 '23 07:04 FedeDP