charts
charts copied to clipboard
WIP: chore(falcosidekick): Values and config Update
What type of PR is this?
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falcosidekick-chart
What this PR does / why we need it:
PR in prevision of FalcoSidekick version bump to 2.27.0. Updating Chart for PRs: falcosecurity/falcosidekick#336 falcosecurity/falcosidekick#337 falcosecurity/falcosidekick#338 falcosecurity/falcosidekick#341 falcosecurity/falcosidekick#346 falcosecurity/falcosidekick#347 falcosecurity/falcosidekick#349 falcosecurity/falcosidekick#353 falcosecurity/falcosidekick#356 falcosecurity/falcosidekick#359 falcosecurity/falcosidekick#360 falcosecurity/falcosidekick#362 falcosecurity/falcosidekick#366
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Do not merge this now.
/do-not-merge
Checklist
- [x] Chart Version bumped
- [x] Variables are documented in the README.md
- [x] CHANGELOG.md updated
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Lowaiz
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval by writing /assign @cpanato
in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/area falcosidekick-chart
Thanks for your PR, as more changes may come before the next release of Sidekick, let's keep it opened and I will ask you to add them in future
@Issif Everything in the 2.27 Milestone of the sidekick has now its config here (The fail in the CI is normal, it can't pull the 2.27 version of the sidekick)
Following this PR https://github.com/falcosecurity/falcosidekick/pull/346 we need now to export the env var NAMESPACE
in all Falcosidekick pods, can you add it following this snippet please:
- name: NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
Hi @Lowaiz, for the falco chart we came up with a solution to keep updated the values
table. It uses the helm-docs that combined with a makefile generates an updated values
table from the comments in the values.yaml
file. Here you can find the commit that introduced helm-docs
in falco: https://github.com/falcosecurity/charts/commit/35830761658320af8a6fd5a0101af4b52e8aae00.
It would be nice to implement the same solution for falcosidekick! Let me know what you think.
It would be nice to implement the same solution for falcosidekick!
Could be great, I'll take a look at that tomorrow.
@alacuku https://github.com/falcosecurity/charts/pull/384
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten
I released the new versions and updated the charts. I co-authored you of course. Thanks.