falcon icon indicating copy to clipboard operation
falcon copied to clipboard

chore: update to latest Redis (aioredis is deprecated)

Open kentbull opened this issue 1 year ago • 2 comments

As of Feb 21, 2023 aioredis-py was archived. See the package repo here: https://github.com/aio-libs-abandoned/aioredis-py

Summary of Changes

A docs update to correct the ASGI doc to use the latest version of Redis and swap the aioredis package for the redis package since aioredis is now included within redis.

Pull Request Checklist

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

  • [ ] Applied changes to both WSGI and ASGI code paths and interfaces (where applicable).
  • [X ] Added tests for changed code.
  • [ X] Prefixed code comments with GitHub nick and an appropriate prefix.
  • [ X] Coding style is consistent with the rest of the framework.
  • [ X] Updated documentation for changed code.
    • [X ] Added docstrings for any new classes, functions, or modules.
    • [ X] Updated docstrings for any modifications to existing code.
    • [ ] Updated both WSGI and ASGI docs (where applicable).
    • [ X] Added references to new classes, functions, or modules to the relevant RST file under docs/.
    • [ ] Updated all relevant supporting documentation files under docs/.
    • [ ] A copyright notice is included at the top of any new modules (using your own name or the name of your organization).
    • [ ] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
  • [ ] Changes (and possible deprecations) have towncrier news fragments under docs/_newsfragments/, with the file name format {issue_number}.{fragment_type}.rst. (Run towncrier --draft to ensure it renders correctly.)

kentbull avatar Jan 18 '24 21:01 kentbull

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (4910dd7) to head (a4221d3).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2204   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         6880      6880           
  Branches      1099      1099           
=========================================
  Hits          6880      6880           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 18 '24 23:01 codecov[bot]

Tests pass, though coverage is not at 100%.

kentbull avatar Jan 19 '24 00:01 kentbull