pkgbuild-introspection icon indicating copy to clipboard operation
pkgbuild-introspection copied to clipboard

restore passing in a pkgbuild path

Open dffischer opened this issue 8 years ago • 4 comments

Commit a07cd59cea847d182b500b0b17c7b7c750b3101c removed the option to specify a file in place of a PKGBUILD, but did not remove the option from the "Usage:" line of the help text. As makepkg supports a -p switch to do a similar thing, the functionality can be restored completely.

The second commit adds a change of directory, similar to what is described in the aforementioned commit message, to even accept PKGBUILDs in arbitrary directions.

I am aware that I could just use makepkg directly, and that ist what I am actually doing in practice. But before switching away, I wanted to leave a pull request fixing the inconsistency with the help text so that others won't be confused like I was. If you instead want to remove the parameter from description entirely, that would be just as fine.

dffischer avatar Mar 09 '16 12:03 dffischer

I'd prefer the chdir take place outside of mksrcinfo, as I suggested in the commit message you cite.

falconindy avatar Mar 09 '16 12:03 falconindy

All chdir takes place only in second commit. You can also only merge the first one, which would allow for PKGBUILDs not named "PKGBUILD" and fits the help text accordingly.

dffischer avatar Mar 09 '16 12:03 dffischer

I really wonder what the use case is for this....

falconindy avatar Mar 09 '16 12:03 falconindy

Templates are, in my case. Expanding the templates in PKGBUILDs and composing parts thereof is easier to be done in dedicated files. Using a directory pkgbuilds/variant/PKGBUILD instead of a file PKBUILD.variant does not only introduce more hierarchy, all supplementary files would also be needed to be copied or linked besides the new PKGBUILD to use it.

dffischer avatar Mar 09 '16 13:03 dffischer