react-loading
react-loading copied to clipboard
Add es-module build with smaller dist size
When I analysed my app bundle I saw that this package looked a bit too beefy and saw that it did not have an es-module dist plus I thought dist size could probably be made a bit smaller.
rollup-plugin-string is used to inline the svgs into the dist for es-modules.
Cheers!
Can you please resolve conflicts @HeyHugo ? Maybe it is wiser to move entirely to rollup instead of webpack? What do you think? Having both of them in place seems a little redundant to me 🤔
Ok will fix conflicts.
Yes building all bundles with rollup probably makes sense. I'll add this to the PR when I have some time soon. Currently the commonjs dist is bundled as a umd build. I'll make this bundle proper commonjs and add a umd build with .min.js extension. Sounds good?
Any chance this can be merged in? I just realized the dist bundle is quite big as well.
@fakiolinho will it be merged?