faker icon indicating copy to clipboard operation
faker copied to clipboard

Update locale en dog breed names

Open mononoken opened this issue 8 months ago • 0 comments

Motivation / Background

I started this PR from noticing data generated from Faker::Creature::Dog.breed had African as a dog breed. This is not a valid dog breed from searching online. There is a breed called Africanis, so I have updated this entry to that.

While updating this value, I noticed some other names that could be cleaned up such as Stbernard being updated to Saint Bernard. I also noted that the docs state to use dash syntax, so I formatted the file first so that it would be easy to follow the name changes.

Additional information

I used https://en.wikipedia.org/wiki/List_of_dog_breeds as a reference. I did not change every inconsistency compared to these wiki names. For example, "Irish Spaniel" is not an entry on the wiki. I mostly tried to target errors and typos.

Checklist

Before submitting the PR make sure the following are checked:

  • [x] This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • [x] Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • [x] Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • [x] Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • [x] Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • [x] You've reviewed and followed the Contributing guidelines.

mononoken avatar Jun 25 '24 06:06 mononoken