faker icon indicating copy to clipboard operation
faker copied to clipboard

Published 20 hours ago • verified publisher icon faker-ruby

Add Faker::Date.weekday_between

Open mattalat opened this issue 3 years ago • 3 comments

Issue#

No-Story

(It partially relates to https://github.com/faker-ruby/faker/issues/1245 but is not intended to satisfy that request)

Description:

This PR adds Faker::Date.weekday_between to produce a weekday within the specified range. This is especially useful for applications that send out many notifications. The method uses the same keyword args as .between.

mattalat avatar Nov 03 '21 23:11 mattalat

hi @mattalat are you still interested in working on this PR? Thanks!

stefannibrasil avatar Aug 28 '22 02:08 stefannibrasil

@stefannibrasil I am still interested, apologies for letting it go stale. It's back on my radar.

mattalat avatar Sep 01 '22 01:09 mattalat

that's awesome, @mattalat thanks for the update :)

stefannibrasil avatar Sep 23 '22 05:09 stefannibrasil

Hey there. In an effort to lighten our load as maintainers, the faker-ruby team is closing stale PRs.

If you still want to reopen this PR, please do the following first:

  • rebase with master to fix any conflicts
  • address code reviews
  • verify this contribution is still relevant (i.e. hasn't been implemented/solved yet)
  • run tests again

Thanks!

stefannibrasil avatar Oct 03 '22 03:10 stefannibrasil