faker icon indicating copy to clipboard operation
faker copied to clipboard

Localization: add RU locale for faker.book module

Open viraxslot opened this issue 8 months ago • 6 comments
trafficstars

Clear and concise description of the problem

There's no Russian localization for "book" module:

// check.js
import { fakerRU as faker } from '@faker-js/faker'

const data = faker.book.author()
console.log(data)
# in terminal
tsx src/check.js
Saul Bellow

Suggested solution

Add translation for "book" module.

Alternative

No response

Additional context

No response

viraxslot avatar Mar 11 '25 23:03 viraxslot

I'd love to implement this. Could you please assign it to me?

viraxslot avatar Mar 11 '25 23:03 viraxslot

I'll remove the s: waiting for user interest label since this is a simple addition for a locale.

xDivisionByZerox avatar Mar 12 '25 00:03 xDivisionByZerox

@viraxslot are you still planning to work on this? Otherwise I'd unassign you again. That way the issue will be open for other people from the community to pick up.

xDivisionByZerox avatar May 22 '25 16:05 xDivisionByZerox

@xDivisionByZerox Hi, thanks for pinging me. Work is in progress, but I can admit it's a lot of things to translate and I didn't have time lately. I'll at least raise the PR with my current progress for better transparency. Maybe somebody would like to help.

viraxslot avatar May 23 '25 08:05 viraxslot

No problem. Our current locale setup would also allow for you to translate only single entries (author, book names, etc) at the time. Every single entry to a locale makes that locale better. So feel free to do little progressions with multiple PRs if that makes it easier for you. :) Just let us know in the PR description that you are planning on doing more in the future so we leave the issue open.

xDivisionByZerox avatar May 23 '25 08:05 xDivisionByZerox

@xDivisionByZerox Great suggestion, I'll split tasks and add checkboxes to the task's description. It'd be nice to merge small changes. Thanks ;)

viraxslot avatar May 23 '25 10:05 viraxslot