faker
faker copied to clipboard
test(animal): unroll animal test loop
alternative idea for #3197 - unroll the loop
Deploy Preview for fakerjs ready!
| Name | Link |
|---|---|
| Latest commit | 4ae6e0ebc6e9dac16ae0c4d034c37f2d2dd4df9a |
| Latest deploy log | https://app.netlify.com/sites/fakerjs/deploys/671cf480c8ee4500087c1fc9 |
| Deploy Preview | https://deploy-preview-3198.fakerjs.dev |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.96%. Comparing base (
975098d) to head (4ae6e0e). Report is 1 commits behind head on next.
Additional details and impacted files
@@ Coverage Diff @@
## next #3198 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 2804 2804
Lines 216974 216974
Branches 961 964 +3
=======================================
+ Hits 216900 216904 +4
+ Misses 74 70 -4
It's deliberately more verbose. I feel that test code shouldn't be too "clever".
I would argue if the tests were in this format it would have been easier to see what had gone wrong when copy pasting the new test for petName. The compiler / autocomplete would guide you that you needed pet_name not petName for the definition.