faker icon indicating copy to clipboard operation
faker copied to clipboard

docs(guide): remove esModuleInterop flag from config

Open ST-DDT opened this issue 1 year ago • 2 comments

AFAICT our users don't need the esModuleInterop (at least for our code). So we should remove them from our guide and I also removed them from our playground.

Could you please verify that there aren't any cases that I missed where our users need it?

ST-DDT avatar Oct 18 '24 14:10 ST-DDT

Deploy Preview for fakerjs ready!

Name Link
Latest commit 26ca1889b2c1f9140ec451a7d0a1b0b3ee51a371
Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/672f3632f227910008b707c7
Deploy Preview https://deploy-preview-3192.fakerjs.dev
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 18 '24 14:10 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.95%. Comparing base (519d212) to head (26ca188). Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3192      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2805     2805              
  Lines      217115   217115              
  Branches      973      970       -3     
==========================================
- Hits       217036   217020      -16     
- Misses         79       95      +16     

see 2 files with indirect coverage changes

codecov[bot] avatar Oct 18 '24 14:10 codecov[bot]

For reference: https://www.typescriptlang.org/tsconfig/#esModuleInterop

xDivisionByZerox avatar Nov 06 '24 17:11 xDivisionByZerox