faker icon indicating copy to clipboard operation
faker copied to clipboard

infra: show eslint progress

Open Shinigami92 opened this issue 1 year ago • 3 comments

why? cause it's cool
no but seriously, with that locally you can see how long you potentially need to wait anymore

docs: https://www.npmjs.com/package/eslint-plugin-file-progress | https://github.com/sibiraj-s/eslint-plugin-file-progress

Shinigami92 avatar Oct 11 '24 19:10 Shinigami92

Deploy Preview for fakerjs ready!

Name Link
Latest commit c1506a3bd63b5587b695683f4b964a6b15d78669
Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6728e304f4b1c80008842e48
Deploy Preview https://deploy-preview-3172.fakerjs.dev
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 11 '24 19:10 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.96%. Comparing base (f9466b5) to head (c1506a3). Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3172   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2805     2805           
  Lines      217098   217098           
  Branches      970      968    -2     
=======================================
  Hits       217018   217018           
  Misses         80       80           

see 1 file with indirect coverage changes

codecov[bot] avatar Oct 11 '24 19:10 codecov[bot]

It slows down a full run of eslint by 3seconds.

79 seconds -> 82 seconds, but it feels more responsive because actually see it doing something.

ST-DDT avatar Oct 12 '24 00:10 ST-DDT

@matthewmayer Sorry, they just released an update that fixes Node 18 support and ships it's own types.

ST-DDT avatar Nov 04 '24 13:11 ST-DDT

There seems to be an issue with the new versions.

ST-DDT avatar Nov 04 '24 13:11 ST-DDT

There seems to be an issue with the new versions.

Can you try v2.1.1, I was manually typing the types, not generated. I made some mistakes.

sibiraj-s avatar Nov 04 '24 13:11 sibiraj-s

Fixed

ST-DDT avatar Nov 04 '24 14:11 ST-DDT

Can't approve, because historically I opened the PR But count me as approved ✅

Shinigami92 avatar Nov 04 '24 15:11 Shinigami92