faker icon indicating copy to clipboard operation
faker copied to clipboard

create icon on simple-icons

Open ianzone opened this issue 1 year ago • 32 comments

to create badges like vitest [![vitest](https://img.shields.io/badge/Vitest-729b1b?logo=Vitest&labelColor=grey)](https://vitest.dev/) the logo has to be available on https://wasm.simpleicons.org/?q=faker, the logo can be added to this repo https://github.com/simple-icons/simple-icons

ianzone avatar Apr 15 '24 18:04 ianzone

For what purpose do you need the logo?

ST-DDT avatar Apr 15 '24 18:04 ST-DDT

to add a badge to my readme file indicates i'm using fakerjs in my project.

ianzone avatar Apr 15 '24 18:04 ianzone

I mean, it gives for the people who use it and doesn't harm anybody who doesn't use it :shrug:

Why would you open an issue here instead at the simple icon repo, tho? :thinking: (I have no idea how the process works)

xDivisionByZerox avatar Apr 15 '24 19:04 xDivisionByZerox

I mean, it gives for the people who use it and doesn't harm anybody who doesn't use it 🤷

I don't know if this issue can harm anybody.

Why would you open an issue here instead at the simple icon repo, tho? 🤔

I guess the author has a better idea about how the icon should look like.

(I have no idea how the process works)

https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon

ianzone avatar Apr 15 '24 19:04 ianzone

I don't know if this issue can harm anybody.

What I wanted to say is: This "features" look very low effort/maintainable for us. So it would not hurt to give it a try.

I guess the author has a better idea about how the icon should look like.

I see (and also read it in the affiliate section in their contributions guidelines). Guess we can discuss it on this week's team meeting.

https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon

Thank you for the link. I was already reading their documentation and intended to rework my comment with a funny twist like: "(I don't know how their process works) I got it now!" I did not expect you to answer this fast :smile:

xDivisionByZerox avatar Apr 15 '24 19:04 xDivisionByZerox

How about this one. It is based on https://github.com/faker-js/faker/blob/next/docs/public/logo.svg

Powered by FakerJS

We might have to clean it up some more though, because at low screen sizes it gets indistinguishable.

ST-DDT avatar Apr 15 '24 20:04 ST-DDT

The outline is good, could you add some color to it? Otherwise, it would be very dark on a dark background. image

ianzone avatar Apr 15 '24 20:04 ianzone

The icons have to be black and transparent. I can add a white background for better visualization on darkmode.

Powered by FakerJS

ST-DDT avatar Apr 15 '24 20:04 ST-DDT

looks cool

ianzone avatar Apr 15 '24 20:04 ianzone

Here a variant with only the face:

Powered by FakerJS

ST-DDT avatar Apr 15 '24 20:04 ST-DDT

IMO it is still very had to see properly when small. Maybe we have to focus just on the face and maybe fill it/invert the interior.

ST-DDT avatar Apr 15 '24 20:04 ST-DDT

Here vitest for comparison:

Powered

ST-DDT avatar Apr 15 '24 20:04 ST-DDT

Or just the magic hat?

ianzone avatar Apr 15 '24 21:04 ianzone

face-2

Powered by FakerJS

ST-DDT avatar Apr 15 '24 21:04 ST-DDT

Or just the magic hat?

I'll try that tomorrow.

ST-DDT avatar Apr 15 '24 21:04 ST-DDT

hat-1

Powered by FakerJS

ST-DDT avatar Apr 17 '24 18:04 ST-DDT

image

ianzone avatar Apr 18 '24 03:04 ianzone

I think the panda head is most visible at small sizes.

matthewmayer avatar Apr 18 '24 03:04 matthewmayer

image

I like image the most

Shinigami92 avatar Apr 18 '24 08:04 Shinigami92

Please don't forget that there is usually no white background:

shield-bare shield-face shield-face-filled shield-hat

ST-DDT avatar Apr 18 '24 08:04 ST-DDT

the icon color can be set here btw https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#7-update-the-json-data-for-simpleiconsorg

Panda head or magic hat works for me.

ianzone avatar Apr 18 '24 08:04 ianzone

And again, image wins for me

I think I found my favorite and decided (for me)

Shinigami92 avatar Apr 18 '24 08:04 Shinigami92

I will make some more variant soon. Especially those with filled faces with default and no rotation.

ST-DDT avatar Apr 18 '24 12:04 ST-DDT

face-3 shield-face2

Powered by FakerJS

ST-DDT avatar Apr 18 '24 13:04 ST-DDT

face-3 shield-face2

Powered by FakerJS

dont like :(

Shinigami92 avatar Apr 18 '24 13:04 Shinigami92

face-filled-2 shield-face-filled2

Powered by FakerJS

ST-DDT avatar Apr 18 '24 13:04 ST-DDT

face-filled-3 shield-face-filled3

Powered by FakerJS

ST-DDT avatar Apr 18 '24 13:04 ST-DDT

For better comparison:

  • face-filled-1 shield-face-filled - ~50% rotation
  • face-filled-2 shield-face-filled2 - original rotation
  • face-filled-3 shield-face-filled3 - zero rotation

ST-DDT avatar Apr 18 '24 13:04 ST-DDT

face-filled-1 wins for me

Shinigami92 avatar Apr 18 '24 14:04 Shinigami92

Team Decision

  • We will use face-filled-1
  • We will create a PR to upload the icon there.

ST-DDT avatar Apr 25 '24 15:04 ST-DDT