chore(deps): update dependency eslint to v9

[renovate[bot]]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
eslint (source)	8.57.0 -> 9.0.0

---

Release Notes

eslint/eslint (eslint)

v9.0.0

Compare Source

---

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[netlify[bot]]

✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	37f402c87b4ba0f6d13947e9f3e7e93b8067c475
🔍 Latest deploy log	https://app.netlify.com/sites/fakerjs/deploys/66993d100ca895000885e433
😎 Deploy Preview	https://deploy-preview-2798.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.96%. Comparing base (0059de9) to head (37f402c).

Additional details and impacted files

@@           Coverage Diff            @@
##             next    #2798    +/-   ##
========================================
  Coverage   99.96%   99.96%            
========================================
  Files        2747     2747            
  Lines      226148   226148            
  Branches      940      588   -352     
========================================
+ Hits       226068   226070     +2     
+ Misses         80       78     -2     

see 1 file with indirect coverage changes

[Shinigami92]

I would like to explore the new eslint v9 and migrate to FlatConfig, so if nobody else has something against that, I would like to "claim" this PR and address some of my time in the upcoming days for this

[renovate[bot]]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

[ST-DDT]

I can confirm that pnpm eslint . freezes if pnpm run build was run/when dist exists. Same for docs/.vitepress/cache not sure how that gets created.

[Shinigami92]

Meanwhile in another project I tested out eslint v9 using ESLINT_USE_FLAT_CONFIG=false and it destroys VSCode's eslint extension, so no auto-fix suggestions are made in VSCode anymore at all. So using this strategy to at least bump up the dependency is non-viable 😕

[Shinigami92]

In the past eslint version (9.2 and 9.3) there were backwards compatibility introduced

[ST-DDT]

What is the status of this PR?

[Shinigami92]

What is the status of this PR?

https://github.com/faker-js/faker/pull/2798#discussion_r1556053323

[ST-DDT]

Small progress:

• https://github.com/gund/eslint-plugin-deprecation/releases/tag/v3.0.0

Although it might not be enough yet.

[Shinigami92]

Small progress:

• https://github.com/gund/eslint-plugin-deprecation/releases/tag/v3.0.0

Although it might not be enough yet.

Please note that I also have a life and can't rush to immediately progress with this PR. Even when I already got notified about that plugin-progress. Now I got double notified.

[ST-DDT]

Please note that I also have a life and can't rush to immediately progress with this PR.

That was not my intention.

Now I got double notified.

Sorry, it is a habit from work, where I document any related progress in the ticket itself, so that other readers of the ticket are aware of the status, without being subscribed to the related ticket.

[xDivisionByZerox]

Small progress:

• https://github.com/gund/eslint-plugin-deprecation/releases/tag/v3.0.0

Although it might not be enough yet.

Please note that I also have a life and can't rush to immediately progress with this PR. Even when I already got notified about that plugin-progress. Now I got double notified.

There was no "@" in the original message. I was happy to be notified about updates towards the progress of the issue. If you feel overwhelmed by messages in an issue/PR, please use githubs notification system to unsubscribe from notifications from them.

[Shinigami92]

Small progress:

• gund/eslint-plugin-deprecation@v3.0.0 (release)

Although it might not be enough yet.

Please note that I also have a life and can't rush to immediately progress with this PR. Even when I already got notified about that plugin-progress. Now I got double notified.

There was no "@" in the original message. I was happy to be notified about updates towards the progress of the issue. If you feel overwhelmed by messages in an issue/PR, please use githubs notification system to unsubscribe from notifications from them.

I'm assigned and so also responsible for this issue I follow the update progress for around a month now Not even a full day passed since the v3 was release I'm watched not only the whole Faker organization but also Vite, Vite-ecosystem, prettier-eco, eslint-eco, and multiple of my projects There are even webhooks I follow

When it is okay to not push other issues and PRs related to my responsibility, it is also okay if we can slow a little bit down with this issue and I can enjoy the last two days of my vacation I hope this is okay

[Shinigami92]

Current output with deprecation/deprecation

Oops! Something went wrong! :(

ESLint: 9.4.0

TypeError: context.getAncestors is not a function
Occurred while linting D:\shinigami\OpenSource\faker\.prettierrc.d.ts:1
Rule: "deprecation/deprecation"
    at getParent (D:\shinigami\OpenSource\faker\node_modules\.pnpm\[email protected][email protected][email protected]\node_modules\eslint-plugin-deprecation\dist\rules\deprecation.js:86:31)
    at isDeclaration (D:\shinigami\OpenSource\faker\node_modules\.pnpm\[email protected][email protected][email protected]\node_modules\eslint-plugin-deprecation\dist\rules\deprecation.js:94:20)
    at identifierRule (D:\shinigami\OpenSource\faker\node_modules\.pnpm\[email protected][email protected][email protected]\node_modules\eslint-plugin-deprecation\dist\rules\deprecation.js:60:13)
    at ruleErrorHandler (D:\shinigami\OpenSource\faker\node_modules\.pnpm\[email protected]\node_modules\eslint\lib\linter\linter.js:1115:48)
    at D:\shinigami\OpenSource\faker\node_modules\.pnpm\[email protected]\node_modules\eslint\lib\linter\safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (D:\shinigami\OpenSource\faker\node_modules\.pnpm\[email protected]\node_modules\eslint\lib\linter\safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (D:\shinigami\OpenSource\faker\node_modules\.pnpm\[email protected]\node_modules\eslint\lib\linter\node-event-generator.js:297:26)    
    at NodeEventGenerator.applySelectors (D:\shinigami\OpenSource\faker\node_modules\.pnpm\[email protected]\node_modules\eslint\lib\linter\node-event-generator.js:326:22)   
    at NodeEventGenerator.enterNode (D:\shinigami\OpenSource\faker\node_modules\.pnpm\[email protected]\node_modules\eslint\lib\linter\node-event-generator.js:340:14)        
 ELIFECYCLE  Command failed with exit code 2.
ERROR: "lint" exited with 2.
 ELIFECYCLE  Command failed with exit code 1.