faker icon indicating copy to clipboard operation
faker copied to clipboard

Pet names

Open Erik-Bjerke opened this issue 2 years ago • 20 comments
trafficstars

Clear and concise description of the problem

There aren't pet names

Suggested solution

Add pet names

Alternative

No response

Additional context

No response

Erik-Bjerke avatar Jun 09 '23 22:06 Erik-Bjerke

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

github-actions[bot] avatar Jun 09 '23 22:06 github-actions[bot]

i would like to work on this issue

Amanshenoy008 avatar Jun 19 '23 17:06 Amanshenoy008

i would like to work on this issue

Currently, we are still waiting on user interest here. We will notify you/everyone when this has gained enough traction. If you are interested in this feature itself, please don't forget to upvote it.

ST-DDT avatar Jun 19 '23 17:06 ST-DDT

This would be very useful for us too!

benrobinsonuk avatar Jun 22 '23 06:06 benrobinsonuk

faker-ruby has https://github.com/faker-ruby/faker/blob/main/lib/locales/en/dog.yml faker.creature.dog.name

matthewmayer avatar Jun 22 '23 08:06 matthewmayer

coming here a year later to say yes I would love pet names

derekmedrano avatar Mar 10 '24 16:03 derekmedrano

This now has 9 upvotes, so it's approaching the point where it gets considered for implementation :) For those who would find this useful, would you just want a generic name that would work for any kind of animal ("Coco", "Max", "Shadow")? Or might you want ones which are specific for a type of animal like cats ("Whiskers", "Mittens", "Felix") etc? (if so, which animals?)

What would the main use-cases be? Like faking a website for a vet clinic? Or a dog-walking service? Or just for fun?

matthewmayer avatar Mar 11 '24 01:03 matthewmayer

This now has 9 upvotes, so it's approaching the point where it gets considered for implementation :) For those who would find this useful, would you just want a generic name that would work for any kind of animal ("Coco", "Max", "Shadow")? Or might you want ones which are specific for a type of animal like cats ("Whiskers", "Mittens", "Felix") etc? (if so, which animals?)

What would the main use-cases be? Like faking a website for a vet clinic? Or a dog-walking service? Or just for fun?

Both would be great. Being able to get generic pet names or specific names by type of animal.

Erik-Bjerke avatar Mar 11 '24 14:03 Erik-Bjerke

Both would be great. Being able to get generic pet names or specific names by type of animal.

Please answer the following questions:

What would the main use-cases be? Like faking a website for a vet clinic? Or a dog-walking service? Or just for fun?

Which types of animals do you need the names for?

ST-DDT avatar Mar 11 '24 15:03 ST-DDT

+1, I need pet names

hikariatama avatar Jun 26 '24 12:06 hikariatama

+1, I need pet names

@hikariatama Please answer the following questions:

What would the main use-cases be? Like faking data for a vet clinic? Or a dog-walking service? Or just for fun?

Which types of animals do you need the names for?

ST-DDT avatar Jun 27 '24 07:06 ST-DDT

Testing a pet apps, dog walking, daycare, vets, pet sitters, kennels, catteries, dog daycare, dog training, breeding and so.

Thanks, Ben

On Thu, Jun 27, 2024, 08:41 ST-DDT @.***> wrote:

+1, I need pet names

@hikariatama https://github.com/hikariatama Please answer the following questions:

What would the main use-cases be? Like faking data for a vet clinic? Or a dog-walking service? Or just for fun?

Which types of animals do you need the names for?

— Reply to this email directly, view it on GitHub https://github.com/faker-js/faker/issues/2206#issuecomment-2194011221, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFMS25I55DECFD7K3V5FYXLZJO6Z3AVCNFSM6AAAAAAZBGH3KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJUGAYTCMRSGE . You are receiving this because you commented.Message ID: @.***>

benrobinsonuk avatar Jun 27 '24 07:06 benrobinsonuk

+1, I need pet names

@hikariatama Please answer the following questions:

What would the main use-cases be? Like faking data for a vet clinic? Or a dog-walking service? Or just for fun?

Which types of animals do you need the names for?

I can't share the details due to NDA, but what I can share is that I need it for the mock data for one of my corporate projects

hikariatama avatar Jun 27 '24 08:06 hikariatama

For your usecase, are dog names different from horse/another animal names? Are there names that could be used for all pets?

ST-DDT avatar Jun 27 '24 10:06 ST-DDT

I think that's probably fine, thanks for that, I'll relay it to the team.

Thanks for your help.

Ben

On Thu, Jun 27, 2024, 11:21 ST-DDT @.***> wrote:

For your usecase, are dog names different from horse names? Are there names that could be used for all pets?

— Reply to this email directly, view it on GitHub https://github.com/faker-js/faker/issues/2206#issuecomment-2194322403, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFMS25OOQT5WSIQURWS4X4TZJPRQ3AVCNFSM6AAAAAAZBGH3KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJUGMZDENBQGM . You are receiving this because you commented.Message ID: @.***>

benrobinsonuk avatar Jun 27 '24 10:06 benrobinsonuk

This now has 13 upvotes, and should be easy enough to implement. Suggest we start with just a generic pet name list for any kind of pet, and then if there's demand later we could add specific cat or dog names etc.

What should the method name be?

faker.animal.pet() faker.animal.petName() ?

matthewmayer avatar Oct 12 '24 02:10 matthewmayer

I would go for petName, because then it is easier to add catName, dogName etc. in the future. pet isn't as clear, because it could return a pet type as well.

ST-DDT avatar Oct 12 '24 09:10 ST-DDT

Can assign to me?

I would also request @ST-DDT if you can point me to a PR where any new method on any module was added.

It will be a good starting point for me to understand what all would be required when new implementation is getting added. Basically to understand how a fully-complete PR should look like after I am done.

suyashgulati avatar Oct 16 '24 22:10 suyashgulati

I would also request @ST-DDT if you can point me to a PR where any new method on any module was added.

You can take a look at #3162, which is the latest new method I know about. I highly encouraged you to have a read through our Contribution Documentation regardless.

xDivisionByZerox avatar Oct 16 '24 23:10 xDivisionByZerox

Thanks @xDivisionByZerox

Yes I have gone through the docs once, also had some refactoring PRs merged previously. Just wanted to glance on how a new implementation PR should look like.

suyashgulati avatar Oct 16 '24 23:10 suyashgulati