faker icon indicating copy to clipboard operation
faker copied to clipboard

Credit Card number parameter

Open ejcheng opened this issue 3 years ago • 5 comments

Screen Shot 2022-01-16 at 2 35 07 PM

In the part of the Finance section of the API docs shown above, I think it would improve the docs if we listed all possible inputs of the 'provider' parameter, such as 'Visa', 'MasterCard', etc. What would happen if someone used gibberish as a parameter there, would an error be thrown?

ejcheng avatar Jan 16 '22 19:01 ejcheng

One interesting challenge here is that each locale is going to have different options. We should consider the best way to represent this, cause I think adding the options is likely a good call! But we should probably add the options for each locale.

clarkerican avatar Jan 17 '22 03:01 clarkerican

One interesting challenge here is that each locale is going to have different options. We should consider the best way to represent this, cause I think adding the options is likely a good call! But we should probably add the options for each locale.

Yes, we probably need to look at different ways to represent this, because this section taking up half of the page is not optimal.

ejcheng avatar Jan 17 '22 05:01 ejcheng

What if you provide the options with an expandable section for each local?

ageddesi avatar Sep 02 '22 06:09 ageddesi

IMO we should describe a way to look these up instead.

ST-DDT avatar Sep 02 '22 16:09 ST-DDT