faker icon indicating copy to clipboard operation
faker copied to clipboard

Highlighted modules on fakerjs.dev are different to README

Open matthewmayer opened this issue 3 years ago • 4 comments
trafficstars

Pre-Checks

Describe the bug

From the README

  • 💌 Locations - Generate valid looking Addresses, Zip Codes, Street Names, States, and Countries!
  • ⏰ Time-based Data - Past, present, future, recent, soon... whenever!
  • 🌏 Localization - Set a locale to generate realistic looking Names, Addresses, and Phone Numbers.
  • 💸 Finance - Create stubbed out Account Details, Transactions, and Crypto Addresses.
  • 👠 Products - Generate Prices, Product Names, Adjectives, and Descriptions.
  • 👾 Hacker Jargon - “Try to reboot the SQL bus, maybe it will bypass the virtual application!”
  • 🧍 Names - Generate virtual humans with a complete online and offline identity.
  • 🔢 Numbers - Of course, we can also generate random numbers and strings.

From https://next.fakerjs.dev/

  • 👠 Products - Generate Prices, Product Names, Adjectives, and Descriptions.
  • 💸 Finance - Create stubbed out Account Details, Transactions, and Crypto Addresses.
  • 💌 Locations - Generate valid Addresses, Zip Codes, Street Names, States, and Countries!
  • 👾 Hacker Jargon - “Try to reboot the SQL bus, maybe it will bypass the virtual application!”
  • ⏰ Time-based Data - Past, present, future, recent, soon... whenever!
  • 🌏 Localization - Set a locale to generate realistic looking Names, Addresses, and Phone Numbers.

Seems these should be consistent? Add Names and Numbers? (And maybe Names should now be People?)

Minimal reproduction code

No response

Additional Context

No response

Environment Info

System:
    OS: macOS 12.6
    CPU: (8) x64 Apple M1
    Memory: 43.63 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.20.0 - /usr/local/bin/node
    npm: 8.19.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 107.0.5304.87
    Firefox: 98.0
    Safari: 16.0

Which module system do you use?

  • [X] CJS
  • [ ] ESM

Used Package Manager

npm

matthewmayer avatar Nov 07 '22 10:11 matthewmayer

I will remove the bug label for now, as the WebSite has just space for 6 cards and this was an undocumented but intentional behavior. But we can rethink about it.

Shinigami92 avatar Nov 07 '22 11:11 Shinigami92

if limited to 6 i think people/names are more important than hacker jargon

matthewmayer avatar Nov 07 '22 12:11 matthewmayer

are you sure its limited to 6? https://vitepress.dev/reference/default-theme-home-page#features-section says "any number of features"

matthewmayer avatar Nov 07 '22 12:11 matthewmayer

I just thought so, but yes it is not hard limited, more like soft limited like we should prevent using prime numbers as these are not divisible for responsive layouts and so a card would wrap into it's own line and so on

Shinigami92 avatar Nov 07 '22 12:11 Shinigami92

@matthewmayer Is this still an issue?

ST-DDT avatar Oct 20 '24 17:10 ST-DDT

I think let's switch out the hacker jargon for person module?

matthewmayer avatar Oct 21 '24 04:10 matthewmayer

Yes. I wpuld probably also change the oder of elements.

  • Person
  • Location
  • Date
  • Finance
  • Product
  • Localization

Are you still interested in creating the PR?

ST-DDT avatar Oct 21 '24 07:10 ST-DDT