faker icon indicating copy to clipboard operation
faker copied to clipboard

Banner doesn't show on https://v6.fakerjs.dev/ and https://v7.fakerjs.dev/

Open matthewmayer opened this issue 2 years ago • 2 comments

Pre-Checks

Describe the bug

it looks like https://github.com/faker-js/faker/pull/1487 was supposed to show a banner "These docs are of an old version" on https://v6.fakerjs.dev/ however no banner is shown. Does this need to be backported?

Minimal reproduction code

No response

Additional Context

No response

Environment Info

n/a

Which module system do you use?

  • [X] CJS
  • [ ] ESM

Used Package Manager

npm

matthewmayer avatar Oct 29 '22 13:10 matthewmayer

Does this need to be backported?

Yes, we have special branches:

  • https://github.com/faker-js/faker/tree/v6
  • https://github.com/faker-js/faker/tree/v7
  • https://github.com/faker-js/faker/tree/v8

We would need to open a PR to backport stuff from next to v7 and so on.

Shinigami92 avatar Oct 29 '22 13:10 Shinigami92

Please backport it to v7 and v6. There is no need to port it to the v8 branch as it will be updated on release.

ST-DDT avatar Oct 29 '22 16:10 ST-DDT