faker
faker copied to clipboard
feat!: another experiment
Alternative draft for #1250
This is another solution and would be what was initially planned as second step after #1254
Codecov Report
Merging #1266 (c66ddf2) into main (462ee5a) will increase coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #1266 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2156 2162 +6
Lines 237025 237071 +46
Branches 1006 1016 +10
=======================================
+ Hits 236126 236182 +56
+ Misses 878 868 -10
Partials 21 21
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/faker.ts | 100.00% <100.00%> (ø) |
|
| src/modules/git/branch.ts | 100.00% <100.00%> (ø) |
|
| src/modules/git/commitEntry.ts | 100.00% <100.00%> (ø) |
|
| src/modules/git/commitMessage.ts | 100.00% <100.00%> (ø) |
|
| src/modules/git/commitSha.ts | 100.00% <100.00%> (ø) |
|
| src/modules/git/hexChars.ts | 100.00% <100.00%> (ø) |
|
| src/modules/git/index.ts | 100.00% <100.00%> (ø) |
|
| src/modules/git/shortSha.ts | 100.00% <100.00%> (ø) |
|
| src/modules/internet/user-agent.ts | 84.39% <0.00%> (+2.64%) |
:arrow_up: |
I liked this approach, in my opinion keeps the code separate and organized.
Closing these experiments for now
@Shinigami92 Do you still need the branch? If not, please delete it.
Commit-ID: c66ddf2659da215f069c7e22592a9d18dcd85f3c
Yes, please do not delete them right now so we have a copy and look into it if needed I just wanted to clean the PR section as we would need to rewrite them anyway as they got to stale