faker icon indicating copy to clipboard operation
faker copied to clipboard

feat!: another experiment

Open Shinigami92 opened this issue 3 years ago • 2 comments

Alternative draft for #1250

This is another solution and would be what was initially planned as second step after #1254

Shinigami92 avatar Aug 12 '22 20:08 Shinigami92

Codecov Report

Merging #1266 (c66ddf2) into main (462ee5a) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1266   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2156     2162    +6     
  Lines      237025   237071   +46     
  Branches     1006     1016   +10     
=======================================
+ Hits       236126   236182   +56     
+ Misses        878      868   -10     
  Partials       21       21           
Impacted Files Coverage Δ
src/faker.ts 100.00% <100.00%> (ø)
src/modules/git/branch.ts 100.00% <100.00%> (ø)
src/modules/git/commitEntry.ts 100.00% <100.00%> (ø)
src/modules/git/commitMessage.ts 100.00% <100.00%> (ø)
src/modules/git/commitSha.ts 100.00% <100.00%> (ø)
src/modules/git/hexChars.ts 100.00% <100.00%> (ø)
src/modules/git/index.ts 100.00% <100.00%> (ø)
src/modules/git/shortSha.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 84.39% <0.00%> (+2.64%) :arrow_up:

codecov[bot] avatar Aug 12 '22 20:08 codecov[bot]

I liked this approach, in my opinion keeps the code separate and organized.

Minozzzi avatar Aug 12 '22 22:08 Minozzzi

Closing these experiments for now

Shinigami92 avatar Jan 29 '23 14:01 Shinigami92

@Shinigami92 Do you still need the branch? If not, please delete it.

Commit-ID: c66ddf2659da215f069c7e22592a9d18dcd85f3c

ST-DDT avatar Jan 30 '23 00:01 ST-DDT

Yes, please do not delete them right now so we have a copy and look into it if needed I just wanted to clean the PR section as we would need to rewrite them anyway as they got to stale

Shinigami92 avatar Jan 30 '23 07:01 Shinigami92