faker icon indicating copy to clipboard operation
faker copied to clipboard

fix(lorem): return word with maximum possible length when expected length is too large

Open hankucz opened this issue 3 years ago • 2 comments

Fixes #1131

hankucz avatar Aug 01 '22 14:08 hankucz

Codecov Report

Merging #1218 (cef5c50) into main (4fa243e) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2153     2153              
  Lines      236521   236537      +16     
  Branches      979      979              
==========================================
+ Hits       235643   235646       +3     
- Misses        857      870      +13     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/lorem/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 81.74% <0.00%> (-2.65%) :arrow_down:
src/modules/finance/index.ts 99.31% <0.00%> (-0.69%) :arrow_down:

codecov[bot] avatar Aug 01 '22 14:08 codecov[bot]

See here for our team decision: https://github.com/faker-js/faker/issues/1131#issuecomment-1205405540

ST-DDT avatar Aug 04 '22 15:08 ST-DDT

This PR is stale and does not match our team decision. Closing for now so someone else can tackle this.

ST-DDT avatar Sep 22 '22 15:09 ST-DDT