faker icon indicating copy to clipboard operation
faker copied to clipboard

build: just read filenames of locales

Open Shinigami92 opened this issue 3 years ago • 1 comments

This is an optimization separated from #1052

Instead of loading all locales while bundling, we can just read their filenames and so it don't transpile all the typescript content in memory

Shinigami92 avatar Jun 18 '22 14:06 Shinigami92

Codecov Report

Merging #1090 (85aa353) into main (f943b78) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1090   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2146     2146           
  Lines      230393   230393           
  Branches      979      979           
=======================================
+ Hits       229582   229583    +1     
+ Misses        790      789    -1     
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 86.37% <0.00%> (-0.58%) :arrow_down:
src/modules/finance/index.ts 100.00% <0.00%> (+0.68%) :arrow_up:

codecov[bot] avatar Jun 18 '22 14:06 codecov[bot]

The way going to #1287 solves this much better, so this PR would get stale anyways

Shinigami92 avatar Aug 20 '22 10:08 Shinigami92