Invalid domain names generated

Open jezen opened this issue 1 year ago • 2 comments

The Faker.Company.fixupName function used in generating domain names replaces spaces with underscores.

This is invalid according to RFC 1035.

The labels must follow the rules for ARPANET host names. They must start with a letter, end with a letter or digit, and have as interior characters only letters, digits, and hyphen. There are also some restrictions on the length. Labels must be 63 characters or less.

May 03 '24 13:05 jezen

I would be happy to accept a PR.

May 03 '24 16:05 psibi

@psibi Here you are: https://github.com/fakedata-haskell/fakedata/pull/53.

May 03 '24 16:05 jezen

New version has been released, closing the issue.

Oct 20 '24 07:10 psibi