ChromeController icon indicating copy to clipboard operation
ChromeController copied to clipboard

A terminal window will show on windows

Open PaleNeutron opened this issue 2 years ago • 3 comments

I found that if we redirect stdin, stdout, stderr in Popen, a console window will show in windows.

https://github.com/fake-name/ChromeController/blob/049a7aa803eb3913e1f73093fa5e2e5839a52d51/ChromeController/transport.py#L178-L185

Can we hide this window by either stop redirecting or pass hiding flag to it? That would be much more graceful.

PaleNeutron avatar Aug 21 '23 02:08 PaleNeutron

I've never run it in a context where I didn't already have a terminal window from which python is executing. .

Also, I've found the stdout of chrome to be useful when it's doing something unexpected, but that's just me.

fake-name avatar Aug 21 '23 06:08 fake-name

If you just want to display Chrome std output to python console,you could remove all redirection from code, since it would still show in python console.

PaleNeutron avatar Aug 22 '23 07:08 PaleNeutron

I'd be happy to accept a PR that does that change, but it's not something I'd pursue myself.

There wasn't a particular motivation between the specific subprocess choice used right now. I think it was probably the first thing I did that worked, so I didn't see a reason to change it.

fake-name avatar Aug 22 '23 08:08 fake-name